Bugzilla Bug 617

From the forums:

1. You can only unload antimatter one unit at a time at the starbase. It can take a while to 
completely empty your ship. Oh, if only the left+right keys did 10 units at a time...

Created an attachment (id=317) [details]
speedy.patch

Let's see how much rotten fruit I can get pelted with over this one...	:)

Here is a patch that makes the left/right controls on the outfit and shipyard
screens act like "turbo" buttons, i.e., they will add/remove 10 crew/fuel at a
time.

This was accomplished by inserting small loops into various sections of code,
rather than simply changing the delta size to something larger; the reason for
this is that the latter approach requires a fair amount of rewriting, and I
wasn't feeling bold enough.

Also, this patch was generated with the "ignore differences in whitespace" flag
enabled, so that reviewers can actually see what I changed rather than how I
re-indented a whole bunch of lines.  As such, anyone who applies this will need
to properly format the affected code.

No offense, but I don't like your proposed patch :P

Created an attachment (id=330) [details]
roster.c.patch

I forgot to include an "accelerator" for the Roster screen in-game; it comes in
quite handy when you first get Fwiffo and need to crew his Eluder.

This patch is complementary to the previous patch -- apply them both for full
effect.

Created an attachment (id=446) [details]
Fuel Side patch of the bug

Here is a different version of the fuel side of the patch, instead of using a
big ‘for’ statement it does the math based on what it is being changed by. 
Also as an added bonus it is 11 lines smaller than the original version. =)

Created an attachment (id=541) [details]
turbo.patch

In the interests of completeness, here is a rewrite of the previous patches
against the 0.6.4 codebase.  The left and right keys add/subtract fuel and crew
by 10, or less than 10 if there isn't enough room.

This is a deviation from the original, and we're always very careful with
things like that. But as the gameplay nor the appearance is modified in any
way, and you can still choose not to use it, and it removes a potential
irritation, I do think this is a good idea.
But it *is* a deviation, so I won't change this until the rest of the core team
have stated their agreement.

Also, we need a cleaner patch (or we might make something ourselves).

I do not like Left/Right for this at all, which always bothered me with this
patch. In any interface using Left/Right for this would be a hack.
PageUp/PageDown is much more acceptable in this case, and then I would have no
problem with the proposed enhancement (have not looked at the code yet).

Created an attachment (id=557) [details]
pgup-pgdn.patch

Here's a version of the patch that uses PgUp/PgDn instead of left/right.

Created an attachment (id=564) [details]
pgup-pgdn.patch (fewer bugs)

The same, but doesn't diable left/right keys in the Shipyard.  Durr...